Add mongo-express command #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
approved these changes
Oct 30, 2024
|
|
||
| - The php extension (phpX.X-mongodb) is set up in `.ddev/config.mongo.yaml` using `webimage_extra_packages`. If you have an earlier `webimage_extra_packages` in your config.yaml, this will override it. You may want to edit your config.yaml to do what you want and remove the config.mongo.yaml. |
There was a problem hiding this comment.
If you have an earlier
webimage_extra_packagesin your config.yaml, this will override it.
This is not true, webimage_extra_packages are merged from all configs, this should be removed.
There was a problem hiding this comment.
Thanks, I will remove this.
rfay
approved these changes
Oct 30, 2024
| @@ -2,38 +2,58 @@ | |||
|
|
|||
| ## What is ddev-mongo? | |||
|
|
|||
| This repository provides Mongo and Mongo Express add-on to [DDEV](https://ddev.readthedocs.io). | |||
| This repository provides Mongo and Mongo Express add-on to [DDEV](https://ddev.readthedocs.io/en/stable/). | |||
There was a problem hiding this comment.
Suggested change
| This repository provides Mongo and Mongo Express add-on to [DDEV](https://ddev.readthedocs.io/en/stable/). | |
| This repository is an add-on that provides Mongo and Mongo Express for [DDEV](https://ddev.readthedocs.io/en/stable/). |
| - | | ||
| #ddev-nodisplay | ||
| #ddev-description:Checking DDEV version | ||
| (ddev debug capabilities | grep corepack >/dev/null) || (echo "Please upgrade DDEV to v1.23+ to enable launching." && false) |
There was a problem hiding this comment.
Rather than this approach, it's easier now to use ddev_version_constraint in the config.mongo.yaml if there is one.
There was a problem hiding this comment.
Sorry, I should have said ddev_version_constraint in the install.yaml., https://github.com/ddev/ddev-addon-template/blob/main/install.yaml#L85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
There was no issue: I wanted to add a command to launch Mongo Express in the browser
How This PR Solves The Issue
Add the
mongo-expresscommandManual Testing Instructions
Automated Testing Overview
mongo-express command is now tested in test.bats
Related Issue Link(s)
Release/Deployment Notes